Discussion:
OpenSSL 1.1.0j version checking bug in configure.ac [PATCH]
Filipp Gunbin
2018-11-22 20:30:26 UTC
Permalink
Hi, I've just found this issue - brackets are eaten by Autoconf.
Quadrigraphs [1] may be used instead. This way configure produces
correct error.

Filipp

[1] https://www.gnu.org/software/autoconf/manual/autoconf-2.66/html_node/Quadrigraphs.html


diff --git a/configure.ac b/configure.ac
index 7379ab35..dcf52230 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2616,7 +2616,7 @@ if test "x$openssl" = "xyes" ; then
AC_MSG_ERROR([OpenSSL >= 1.0.1 required (have "$ssl_library_ver")])
;;
100*) ;; # 1.0.x
- 101000[0123456]*)
+ 101000@<:@0123456@:>@*)
# https://github.com/openssl/openssl/pull/4613
AC_MSG_ERROR([OpenSSL 1.1.x versions prior to 1.1.0g have a bug that breaks their use with OpenSSH (have "$ssl_library_ver")])
;;
Christian Weisgerber
2018-11-22 21:48:59 UTC
Permalink
Post by Filipp Gunbin
Hi, I've just found this issue - brackets are eaten by Autoconf.
Quadrigraphs [1] may be used instead.
That's the sort of solution from somebody who has read the manual
but hasn't seen many actual autoconf scripts. :-)
Post by Filipp Gunbin
- 101000[0123456]*)
Normally you just use [[ ]]:

+ 101000[[0123456]]*)
--
Christian "naddy" Weisgerber ***@mips.inka.de
Damien Miller
2018-11-22 23:47:23 UTC
Permalink
Post by Filipp Gunbin
Hi, I've just found this issue - brackets are eaten by Autoconf.
Quadrigraphs [1] may be used instead. This way configure produces
correct error.
Thanks - I've committed this (with naddy@'s tweak) to both the master
and V_7_9 stable branches.
Filipp Gunbin
2018-11-23 00:49:41 UTC
Permalink
Post by Damien Miller
Post by Filipp Gunbin
Hi, I've just found this issue - brackets are eaten by Autoconf.
Quadrigraphs [1] may be used instead. This way configure produces
correct error.
and V_7_9 stable branches.
Thanks!
Filipp

Loading...